Opened on 05/31/2016 at 10:01:44 AM

Closed on 05/31/2016 at 10:13:09 AM

#4091 closed change (fixed)

Don't test $~media in "Result cache checks" test, unsupported in Chrome

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29345394/

Description

Background

"Result cache checks" test currently fails in Chrome because $~media is considered equivalent to $~other there.

What to change

Remove the $~media flag from the filters, it isn't really necessary for this test.

Attachments (0)

Change History (3)

comment:1 Changed on 05/31/2016 at 10:06:06 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/31/2016 at 10:12:32 AM by abpbot

A commit referencing this issue has landed:
​Issue 4091 - Don't test $~media in "Result cache checks" test, unsupported in Chrome

comment:3 Changed on 05/31/2016 at 10:13:09 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.