Opened on 03/11/2014 at 11:35:15 AM

Closed on 01/06/2015 at 05:35:13 PM

Last modified on 02/19/2015 at 07:36:57 AM

#41 closed defect (fixed)

Populate AppInfo.applicationVersion field properly

Reported by: trev Assignee: eric@adblockplus.org
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5171515343503360/

Description

Currently Adblock Plus for Internet Explorer only populates the AppInfo.application field but not AppInfo.applicationVersion. This field should be populated properly with the Internet Explorer version, otherwise we cannot distinguish version-specific issues properly.

Attachments (0)

Change History (9)

comment:1 Changed on 06/16/2014 at 12:12:22 PM by eric@adblockplus.org

  • Ready unset

FYI. The current function that determines the IE version no longer retrieves the correct version with IE 10, because that version of IE has changed the way it records the version in the registry. See http://support.microsoft.com/kb/969393 for more information. The most relevant sentence: "The version string value for Internet Explorer 10 is 9.10.9200.16384, and the svcVersion string value is 10.0.9200.16384."

comment:2 Changed on 06/21/2014 at 08:46:45 PM by eric@adblockplus.org

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 06/21/2014 at 08:47:40 PM by eric@adblockplus.org

  • Owner set to eric@adblockplus.org

comment:4 Changed on 07/09/2014 at 12:36:01 PM by philll

  • Platform set to Internet Explorer

comment:5 Changed on 07/15/2014 at 11:16:56 AM by oleksandr

  • Ready set

comment:6 Changed on 07/29/2014 at 01:16:35 PM by sergz

Currently Adblock Plus for Internet Explorer only populates the AppInfo.application ...

The essential point here is that the speech is about AdblockPlusEngine. The engine should not be aware about the browser. The engine has no relationship with any browser, the client of the engine can be some UI-less service, or test client? If we really need some additional information here, it should come as a part of the first message of each client and should be client specific.

comment:7 Changed on 07/29/2014 at 01:22:47 PM by trev

It can come as a command line parameter when the engine is started, like the browser locale. However, given that the engine is really a broker process for the various browser processes, I wouldn't get too religious about this.

comment:8 Changed on 01/06/2015 at 05:35:13 PM by eric@adblockplus.org

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 02/19/2015 at 07:36:57 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from eric@adblockplus.org.
 
Note: See TracTickets for help on using tickets.