Opened on 06/07/2016 at 04:26:08 PM
Closed on 06/08/2016 at 08:44:07 PM
#4133 closed change (fixed)
Switch to new FilterNotifier API in UI module
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
FilterNotifier.addListener() is deprecated. In addition to the occurrence replaced in #4131 there is another spot in the UI module calling that method.
What to change
Replace FilterNotifier.addListener() call by multiple FilterNotifier.on() calls.
Attachments (0)
Change History (3)
comment:1 Changed on 06/07/2016 at 04:34:11 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 06/08/2016 at 08:43:34 PM by abpbot
comment:3 Changed on 06/08/2016 at 08:44:07 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4133 - Switch to new FilterNotifier API in UI module