Opened on 06/10/2016 at 09:40:13 PM
Closed on 10/14/2016 at 01:32:19 PM
Last modified on 10/19/2016 at 11:20:35 AM
#4147 closed change (fixed)
Add a high-res version of the 32x32 ABP icon
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | christiane | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Background
While #4142 added a high-res version of the 16x16 toolbar icon, the larger icon (displayed for example if ABP is placed inside the "hamburger menu") remains unchanged. It could look better on high-res displays.
What to change
On screens with higher pixel density use attached abp-status-48.png and abp-status-64.png instead of abp-status-32.png.
Attachments (2)
Change History (8)
Changed on 10/14/2016 at 09:06:55 AM by trev
Changed on 10/14/2016 at 09:07:11 AM by trev
64x128 variant
comment:1 Changed on 10/14/2016 at 09:09:10 AM by trev
- Description modified (diff)
- Owner set to trev
- Ready set
comment:2 Changed on 10/14/2016 at 09:16:31 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 10/14/2016 at 01:31:42 PM by abpbot
A commit referencing this issue has landed:
Issue 4147 - Add a high-res version of the 32x32 ABP icon
comment:4 Changed on 10/14/2016 at 01:32:19 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 10/14/2016 at 01:32:30 PM by trev
- Milestone changed from Adblock-Plus-for-Chrome-Opera-Safari-next to Adblock-Plus-for-Firefox-next
comment:6 Changed on 10/19/2016 at 11:20:35 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. New icon appears to be used, looks fine in both states and in multiple locations (toolbar, hamburger menu). Tested on 2800 x 1620 resolution.
2.7.3-4214-beta
Firefox 39 / 49 / Windows 7
Firefox 45 / Nightly / Ubuntu 14.04
48x96 variant