Opened on 06/29/2016 at 02:31:55 AM
Closed on 10/11/2019 at 02:30:58 AM
#4204 closed change (rejected)
Make $genericblock work better
| Reported by: | fanboy | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | arthur, kzar, sebastian, mapx | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by mapx)
Currently $genericblock isn't a very useful filter especially if we're trying to counter Anti-adblock filters. Still unsure how it works properly.
Most sites will use a specific string to check (if not an element). say "/advert.js" http://somesite.com/advert.js
An alternative way $genericblock could work, still block
||filters
(so site specific rules, and
||adserverrules). But if we add the following
@@||somesite.com^$genericblockIt'll cover any attempt to have revolving filenames matching the generic filters in easylist_general_block.txt
Attachments (0)
Change History (6)
comment:3 Changed on 06/29/2016 at 01:51:49 PM by mapx
- Cc arthur kzar sebastian trev mapx added
comment:4 Changed on 12/21/2017 at 11:27:49 AM by fhd
- Cc trev removed
comment:5 Changed on 10/10/2019 at 11:00:50 AM by greiner
- Component changed from Unknown to Core
comment:6 Changed on 10/11/2019 at 02:30:58 AM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.