Opened on 07/12/2016 at 03:48:45 PM

Closed on 09/14/2016 at 09:00:19 AM

#4240 closed change (fixed)

Put braces on each and every block

Reported by: rjeschke Assignee: asmirnov
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29349000/

Description

Background

I insist on having (curly) braces on _every_ block, be it in Java or C++. This ensures consistent code and makes errors easier to spot.

What to change

Put braces around every block.

Attachments (0)

Change History (3)

comment:1 Changed on 08/02/2016 at 11:01:06 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/14/2016 at 08:57:50 AM by abpbot

A commit referencing this issue has landed:
​Issue 4240 - Put braces on each and every block

comment:3 Changed on 09/14/2016 at 09:00:19 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from asmirnov.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.