Opened on 05/05/2014 at 12:48:30 PM

Closed on 06/02/2014 at 12:43:37 PM

Last modified on 06/09/2014 at 11:04:02 AM

#427 closed defect (fixed)

Remove usage of non-standard function syntax

Reported by: tschuster Assignee: tschuster
Priority: P3 Milestone: Adblock-Plus-2.6.4-for-Firefox
Module: Core Keywords:
Cc: trev Blocked By: #656
Blocking: #312, #517 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):


Firefox has these three non-standard syntax extensions:
function f(x) x + 1;
{get() 1} {set(v) v = 1;}

Attachments (0)

Change History (12)

comment:1 Changed on 05/10/2014 at 12:48:40 PM by tschuster

  • Review URL(s) modified (diff)

comment:2 Changed on 05/12/2014 at 08:55:09 AM by philll

You might want to provide a bit more detail in your issues in future to enable testers to work with it.

comment:3 Changed on 05/12/2014 at 11:20:47 AM by tschuster

Ok, it's not clear to me what one would manually? test here. This is purely a code change that shouldn't have any observable effects. Should I just say that?

comment:4 Changed on 05/12/2014 at 01:35:30 PM by philll

Even if there is no direct change of functionality, it should be obvious to testers in general, which functional parts a code change belongs to such that they can verify them still working as before. That's basically, why there should be a background section in every change issue. Also, if not sufficiently obvious, a "what to change" section might make sense.

comment:5 Changed on 05/19/2014 at 07:42:40 AM by trev

  • Blocking 517 added

comment:6 Changed on 06/02/2014 at 12:40:59 PM by tschuster

  • Owner set to tschuster

comment:8 Changed on 06/02/2014 at 12:43:37 PM by tschuster

  • Resolution set to fixed
  • Status changed from new to closed

comment:9 follow-up: Changed on 06/02/2014 at 07:28:06 PM by barbaz

With this change, latest dev builds now require at least Gecko 22, see

comment:10 Changed on 06/03/2014 at 02:28:53 PM by trev

  • Cc trev added

comment:11 in reply to: ↑ 9 Changed on 06/03/2014 at 02:59:08 PM by trev

  • Component changed from Unknown to Core
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Priority changed from Unknown to P3
  • Ready set

Replying to barbaz:

With this change, latest dev builds now require at least Gecko 22, see

Big ouch :-(

Adblock Plus 2.6.2 was already out, had to respin the release because of this - changing compatibility with this release wasn't the idea. - backed out this change - relanded after the release, this time with appropriate compatibility info changes.

comment:12 Changed on 06/09/2014 at 11:04:02 AM by tschuster

  • Blocked By 656 added

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tschuster.
Note: See TracTickets for help on using tickets.