Opened on 05/06/2014 at 10:27:13 AM
Closed on 09/17/2014 at 09:21:36 AM
Last modified on 09/17/2014 at 09:41:19 AM
#433 closed change (fixed)
Adjust to $sitekey-related changes of the Matcher API (Platform)
| Reported by: | trev | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.6-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #406, #1328 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
#431 changes the Matcher API that should make it simpler to implement $sitekey functionality in Chrome/Opera/Safari.
What to change
Function processKeyException() in lib/whitelisting.js will currently mark the entire frame as whitelisted if it sees a valid signature and a matching filter. Rather than doing this it should merely verify the signature and record the key for the frame. That key can later be passed in to Matcher.matchesAny() call in webRequest.js.
Attachments (0)
Change History (6)
comment:1 Changed on 05/28/2014 at 05:25:58 AM by fhd
- Priority changed from P1 to P2
comment:2 Changed on 09/05/2014 at 10:15:40 AM by greiner
- Blocking 1328 added
comment:3 Changed on 09/10/2014 at 03:50:23 PM by greiner
- Platform set to Unknown
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 09/10/2014 at 03:51:29 PM by greiner
- Owner set to greiner
comment:5 Changed on 09/17/2014 at 09:21:36 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 09/17/2014 at 09:41:19 AM by greiner
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockpluschrome/rev/57f5dbea9d24