Opened on 08/24/2016 at 10:19:39 AM
Closed on 08/31/2016 at 10:39:30 AM
Last modified on 09/05/2016 at 05:03:03 PM
#4356 closed defect (rejected)
EU flag circle is distorted on eyeo.com/team
Reported by: | juliandoucette | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Websites | Keywords: | |
Cc: | saroyanm, juliandoucette, Ross, kvas, greiner | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by kvas)
Environment
All
How to reproduce
- Goto https://eyeo.com/team
- Find Ross Green
- See EU flag
Observed behaviour
Star circle is distorted
Expected behaviour
Star circle should not be distorted
Attachments (1)
Change History (14)
comment:1 Changed on 08/24/2016 at 10:20:52 AM by juliandoucette
comment:2 Changed on 08/24/2016 at 01:23:42 PM by kvas
- Description modified (diff)
- Summary changed from UN flag circle is distorted on eyeo.com/team to EU flag circle is distorted on eyeo.com/team
A small correction: Ross's flag is an EU flag, not a UN flag (speaking of which, maybe I should ask for that one for myself, or even better: planet earth flag anyone? ;)
comment:3 Changed on 08/25/2016 at 09:29:43 AM by greiner
- Cc greiner added
comment:4 follow-ups: ↓ 7 ↓ 8 Changed on 08/25/2016 at 09:55:57 AM by Ross
I did think about asking for an Earth flag before opting for the EU flag, however none are official (maybe in 200 years :) and the "rings" version doesn't look particularly good at that size.
comment:5 Changed on 08/25/2016 at 10:11:42 AM by kvas
I agree with all your arguments.
Anyway, the rings version does represent the right values, in my opinion, and I think I managed to produce a decent small icon of it so I'll try to get that for myself. Let's see how it comes out.
comment:6 Changed on 08/25/2016 at 10:38:44 AM by greiner
Note that whenever you make changes to how the flag icons are created, please update the instructions in the README as well as apply the changes to existing icons for consistency and make sure that the quality of those doesn't deteriorate (e.g. important parts of other flags shouldn't be cut off).
comment:7 in reply to: ↑ 4 Changed on 08/29/2016 at 03:57:50 PM by saroyanm
Replying to Ross:
I did think about asking for an Earth flag before opting for the EU flag, however none are official (maybe in 200 years :) and the "rings" version doesn't look particularly good at that size.
Ross are you still want to use EU flag, or switch to Earth flag while @kvas made a version for Earth flag and wish to replace his ?
Changed on 08/29/2016 at 03:58:52 PM by saroyanm
Earth flag
comment:8 in reply to: ↑ 4 Changed on 08/29/2016 at 04:00:17 PM by saroyanm
@Ross you can check the one provided by @Vasily here.
comment:9 follow-up: ↓ 10 Changed on 08/31/2016 at 10:24:47 AM by Ross
I'll switch to the Earth flag too if that's okay :)
comment:10 in reply to: ↑ 9 Changed on 08/31/2016 at 10:36:21 AM by saroyanm
comment:11 Changed on 08/31/2016 at 10:39:30 AM by saroyanm
- Resolution set to rejected
- Status changed from new to closed
While Ross also decided to switch the flag to the Earth flag I have to mark the issue as rejected, but in the good way :) In future if we will be asked to add EU flag, we can ask our designers maybe to create one, or create a better one manually, but it's a matter of free time.
comment:12 follow-up: ↓ 13 Changed on 09/05/2016 at 04:49:19 PM by greiner
Instead of using a flag that I assume most people have never seen, what about (a) using a generic placeholder image such as the new eyeo icon or (b) simply not adding a flag for people who don't want to be associated with a country?
comment:13 in reply to: ↑ 12 Changed on 09/05/2016 at 05:03:03 PM by kvas
Replying to greiner:
Instead of using a flag that I assume most people have never seen, what about (a) using a generic placeholder image such as the new eyeo icon or (b) simply not adding a flag for people who don't want to be associated with a country?
At least in my case, I specifically asked for the flag of planet Earth so I would like to keep it even though many people wouldn't recognise it. I think Ross had more or less similar position (correct me if I'm wrong).
However, if someone doesn't want any specific country or other flag, your suggestion would be a good way forward. Not having any flag seems like a reasonable option to provide and Eyeo ninja flag would also be nice to have.
(I CC'd Ross and kvas because they pointed this out to me.)