Opened on 05/07/2014 at 06:24:16 AM
Closed on 05/07/2014 at 06:49:34 AM
Last modified on 10/22/2014 at 11:32:51 AM
#437 closed defect (fixed)
Chrome, ABP 1.8, right click "block element" broken
| Reported by: | mapx | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8.1-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Environment
windows xp
chrome 34, 36
ABP 1.8.0.1176 (or stable 1.8)
How to reproduce
right click an image, click Block Element ==> no effect
errors in console (row 109 from background.js):
background.js:109 (contextMenuItem.onclick)
page.sendMessage({type: "clickhide-new-filter", filter: srcUrl});
Error in event handler for contextMenus: undefined is not a function
Stack trace: TypeError: undefined is not a function
at contextMenuItem.onclick (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/background.js:109:12)
at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
at extensions::contextMenus:42:19
at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
at EventImpl.dispatchToListener (extensions::event_bindings:395:22)
at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:89:26)
at EventImpl.dispatch_ (extensions::event_bindings:378:35)
at dispatchArgs (extensions::event_bindings:246:26)
at dispatchEvent (extensions::event_bindings:255:7)
reported also in the forum:
https://adblockplus.org/forum/viewtopic.php?f=10&t=22998
Attachments (0)
Change History (5)
comment:1 Changed on 05/07/2014 at 06:31:22 AM by sebastian
- Owner set to sebastian
comment:2 Changed on 05/07/2014 at 06:41:06 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 05/07/2014 at 06:49:34 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/07/2014 at 02:06:21 PM by philll
- Ready set
- Verified working set
comment:5 Changed on 10/22/2014 at 11:32:51 AM by sebastian
- Cc sebastian removed
https://hg.adblockplus.org/adblockpluschrome/rev/50b5a7a9e16f