Opened on 09/12/2016 at 09:27:54 AM
Closed on 11/10/2017 at 11:15:18 AM
#4409 closed defect (rejected)
Toolbar icon is too large on older Firefox version and high-DPI screens
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Adblock Plus 2.7.3.4198-beta, Firefox 38, Mac OS X 10.11 with Retina screen
How to reproduce
- Start Firefox, look at the ABP toolbar icon.
Observed behaviour
Toolbar icon is too wide, stretching the entire toolbar button.
Expected behaviour
Toolbar icon size is 32x32, like in newer Firefox versions.
Attachments (0)
Change History (10)
comment:1 Changed on 09/12/2016 at 09:29:23 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 09/19/2016 at 12:07:45 PM by abpbot
comment:3 Changed on 09/19/2016 at 12:08:50 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 09/27/2016 at 06:17:17 AM by diceman2037
has broken the large and small icons on firefox 44 @ 125% dpi
all i see is the drop down arrow now.
tested in existing and new profile
comment:5 Changed on 10/06/2016 at 12:57:50 PM by abpbot
A commit referencing this issue has landed:
Backed out changeset 8df828ef2894 (Issue 4409 - Fixed too large toolbar icon in older Firefox versions on high-DPI screens), it caused issue 4445 on Windows
comment:6 Changed on 10/06/2016 at 01:05:04 PM by trev
- Milestone Adblock-Plus-for-Firefox-next deleted
- Priority changed from P3 to P4
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening since the fix has been rolled back - on Windows that icon has paddings, so the resulting icon size is wrong (see #4445). As things stand, I don't really see a solution which would work reliably everywhere.
comment:7 Changed on 10/08/2016 at 12:10:42 PM by juliandoucette
I think this issue should be a higher priority. Picky users (like me) will install another ad blocker based on how good the toolbar (and menu) icon looks alone. I suspect that the product team would back me up on this.
comment:8 Changed on 10/08/2016 at 01:34:59 PM by trev
This issue affects Firefox 40 and below I think, current release is Firefox 49 - and it might be Mac-only, I didn't check. Why should this issue have a higher priority?
Note also that resolving this issue appears to be non-trivial to say the least - at least without breaking things on other platforms.
comment:9 Changed on 10/08/2016 at 10:45:04 PM by juliandoucette
Note also that resolving this issue appears to be non-trivial to say the least - at least without breaking things on other platforms.
Noted.
This issue affects Firefox 40 and below I think, current release is Firefox 49 - and it might be Mac-only, I didn't check. Why should this issue have a higher priority?
It shouldn't.
---
I think I misinterpreted the issue and spoke too soon here. I'm sorry @trev.
comment:10 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from reopened to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
A commit referencing this issue has landed:
Issue 4409 - Fixed too large toolbar icon in older Firefox versions on high-DPI screens