Opened on 09/20/2016 at 10:07:08 AM
Closed on 09/20/2016 at 11:44:36 AM
Last modified on 10/19/2016 at 12:34:25 PM
#4449 closed change (fixed)
Use 'websocket' type for WebSocket connections
| Reported by: | kzar | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev | Blocked By: | #4387 |
| Blocking: | #4372 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Background
In issue #4387 we added the websocket request type, now we want to use from adblockplus.
What to change
- Update adblockpluscore dependency to revision d0d7a9d27bf7.
- Add WEBSOCKET to supported types.
- Add the necessary string to display websocket connections in Blockable items list.
As the dependency update also imports that changes from #4353, updating file mapping to add lib/coreUtils.js to the package is also necessary.
Attachments (0)
Change History (8)
comment:1 Changed on 09/20/2016 at 10:27:44 AM by kzar
- Sensitive set
comment:2 Changed on 09/20/2016 at 11:12:02 AM by trev
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
- Sensitive unset
comment:3 Changed on 09/20/2016 at 11:12:49 AM by trev
- Owner set to trev
comment:5 Changed on 09/20/2016 at 11:29:51 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/20/2016 at 11:40:35 AM by abpbot
comment:7 Changed on 09/20/2016 at 11:44:36 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 10/19/2016 at 12:34:25 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Working as expected using both $websocket and |wss:// filters. Hits are counted, appears in blockable items list. Tested against https://www.websocket.org/echo.html and those adult sites that use websockets to stream in ads.
ABP 2.7.3-4214-beta
Firefox 39 / 45 / 49 / 52-Nightly / Windows 7
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4449 - Use 'websocket' type for WebSocket connections