Opened on 09/22/2016 at 01:21:02 PM
Closed on 10/04/2016 at 02:23:53 PM
#4464 closed defect (fixed)
updateUpdateManifests script relies on sitescripts.extensions.android which is no longer there
| Reported by: | trev | Assignee: | kvas |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | sebastian, kvas | Blocked By: | |
| Blocking: | #3759 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
How to reproduce
- Create a clean copy of sitescripts repository.
- Run python -m sitescripts.extensions.bin.updateUpdateManifests
Observed behaviour
The script errors out, it attempts to import from sitescripts.extensions.android module which was removed in #3759.
Expected behaviour
No errors. Currently, this is only working on the server because of a stale android.pyc file.
What to change
Add the get_min_sdk_version() function from the removed sitescripts.extensions.android module to sitescripts.extensions.bin.updateUpdateManifests, and remove the dead import.
Attachments (0)
Change History (9)
comment:1 Changed on 09/22/2016 at 01:27:04 PM by sebastian
- Cc kvas added
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 09/22/2016 at 01:28:31 PM by sebastian
- Component changed from Unknown to Sitescripts
comment:6 Changed on 09/22/2016 at 04:39:11 PM by kvas
- Owner set to kvas
comment:7 Changed on 09/22/2016 at 04:39:27 PM by kvas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 10/04/2016 at 02:21:37 PM by abpbot
comment:9 Changed on 10/04/2016 at 02:23:53 PM by kvas
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Fixes 4464 - Restore get_min_sdk_version() function from sitescripts.extensions.android module that was deleted by #3759