Opened on 09/28/2016 at 07:38:37 AM

Closed on 10/10/2016 at 01:28:16 PM

#4479 closed defect (fixed)

[codingtools] Default editorconfig settings are not being applied

Reported by: fhd Assignee: fhd
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: kvas, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29355231/

Description

Environment

  • EditorConfig C Core 0.12.1.

How to reproduce

  1. Create a symlink from .editorconfig in the parent directory of the adblockpluschrome repository to codingtools/editorconfig.
  2. In the adblockpluschrome repository, run editorconfig $(pwd)/background.js.

Observed behaviour

editorconfig should print the default properties relevant to background.js (e.g. indend_size).

Expected behaviour

editorconfig prints nothing at all.

Attachments (0)

Change History (4)

comment:1 Changed on 09/28/2016 at 07:44:20 AM by fhd

  • Owner set to fhd
  • Review URL(s) modified (diff)

comment:2 Changed on 09/28/2016 at 07:44:36 AM by fhd

  • Status changed from new to reviewing

comment:3 Changed on 10/10/2016 at 01:28:03 PM by abpbot

A commit referencing this issue has landed:
​Fixes 4479 - Default editorconfig settings not being applied

comment:4 Changed on 10/10/2016 at 01:28:16 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.