Opened on 09/30/2016 at 01:29:48 AM
Closed on 10/05/2016 at 02:01:56 PM
Last modified on 12/15/2016 at 05:20:38 AM
#4486 closed defect (fixed)
Broken detection whether a document (root frame) is whitelisted or not
| Reported by: | oleksandr | Assignee: | sergz |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr, sergz, philll | Blocked By: | |
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Rraceanu | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sergz)
Environment
ABP for IE, master and issue-119-inject-css bookmarks.
How to reproduce
- Go to http://google.com
- Search for ad heavy term like 'flower shop' or 'buy iphone'
- Observe no Acceptable Ads
- Check Acceptable Ads switch in settings to make sure they are enabled
- Disable ABP on google.com and refresh the page to make sure the ad is actually served.
Expected behaviour
Acceptable Ads should be shown based on a setting on the settings page.
Additional info
It affects only certain filters, see comment #6.
Attachments (0)
Change History (9)
comment:2 Changed on 09/30/2016 at 09:25:03 AM by sergz
- Owner set to sergz
comment:3 Changed on 09/30/2016 at 09:25:30 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 09/30/2016 at 03:28:47 PM by abpbot
A commit referencing this issue has landed:
Issue 4486 - fix document URL parameter value when calling GetWhitelistingFilter
comment:5 Changed on 10/05/2016 at 02:01:56 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 10/06/2016 at 09:24:53 AM by sergz
- Cc philll added
- Description modified (diff)
- Summary changed from Acceptable Ads switch is broken on google.com with CSS injection enabled to Broken detection whether a document (root frame) is whitelisted or not
The issue is that we check whether the document is whitelisted (as well as element hiding) a wrong way.
For example, there is a filter @@||www.google.de^$elemhide,~third-party (on my machine, google redirects to google.de, but it does not matter) and in the engine we call Main.cpp::GetWhitelistingFilter("https://www.google.de/#q=iphone", empty vector, CONTENT_TYPE_ELEMHIDE) which calls GetWhitelistingFilter(urlArg, "", type) and it returns an empty string. However, it should use URL as document URL instead of an empty string, thus call GetWhitelistingFilter(urlArg, urlArg, type).
It has been introduced here.
It does not affect for instance filters like @@||example.org^$elemhide which are created when a web site is manually whitelisted.
comment:7 Changed on 10/18/2016 at 02:06:01 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
comment:8 Changed on 11/08/2016 at 12:59:26 AM by rraceanu
- Tester changed from Unknown to Rraceanu
comment:9 Changed on 12/15/2016 at 05:20:38 AM by rraceanu
- Verified working set
Change successfully implemented, AA ads are shown on whitelisted websites, verified on IE 10 Windows 8, IE 11 Windows 10, ABP version 1.5.856
Short fix for the present.