Opened on 05/08/2014 at 02:02:21 PM
Closed on 05/15/2014 at 10:33:41 AM
Last modified on 05/26/2014 at 01:39:22 PM
#449 closed change (fixed)
Do not override toolbar button's context menu unnecessarily
| Reported by: | trev | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.6.2-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | greiner, saroyanm | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
By default, we currently show the Adblock Plus menu both on left and right clicks on the toolbar icon (same with status bar icon if it exists). Main reason is that the left click action can be redefined, then you need to right click for the menu. This will be suboptimal as we move to the bubble UI for the menu.
What to change
Only override the default context menu if the left click action has actually been redefined, allow the standard context menu to appear by default.
Attachments (0)
Change History (8)
comment:1 Changed on 05/08/2014 at 03:18:58 PM by saroyanm
- Owner set to saroyanm
comment:2 Changed on 05/14/2014 at 03:19:21 PM by saroyanm
comment:3 Changed on 05/14/2014 at 03:26:59 PM by trev
If this isn't reviewed then it isn't fixed.
comment:4 Changed on 05/14/2014 at 03:38:19 PM by saroyanm
Sorry for being not concrete.
So what I wanted to ask is whether this should be reviewed with whole Bubble UI review, or should I create separate review for this issue ?
comment:5 Changed on 05/14/2014 at 04:10:23 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 05/14/2014 at 04:11:32 PM by saroyanm
I've decided to create it separate while not that much changes.
Please have a look Wladimir when you have time.
Thanks.
comment:7 Changed on 05/15/2014 at 10:33:41 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/26/2014 at 01:39:22 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
This is ,fixed,
but not sure how we should proceed with the issue.
Maybe we can mark the issue as fixed after whole Bubble UI review ?
Anyway if we want to proceed with this issue separately, I can test it with old style overlay.xul.