Opened on 10/06/2016 at 09:11:26 AM
Closed on 10/06/2016 at 05:49:37 PM
Last modified on 10/25/2016 at 08:35:55 AM
#4495 closed change (fixed)
Remove adblockplustests dependency
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.12.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, trev, rraceanu | Blocked By: | #4223 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
For issue #4223 we've been migrating unit tests over from the adblockplustests repository to adblockpluscore. adblockpluschrome makes use of some of those tests and so they should be removed.
What to change
- Remove the adblockplustests dependency.
- Update the test runner for adblockpluschrome so the migrated tests are no longer included.
- Import the preference tests from adblockplustests, removing the branching for Firefox support.
Hints for testers
This is not an issue which you can really test. The developers (are supposed to!) run these unit tests when making changes and should notice if they have broken.
Attachments (0)
Change History (5)
comment:1 Changed on 10/06/2016 at 09:21:24 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 10/06/2016 at 09:29:52 AM by kzar
- Description modified (diff)
- Summary changed from Update adblockplustests dependency, remove migrated core tests to Remove adblockplustests dependency
comment:3 Changed on 10/06/2016 at 05:42:26 PM by abpbot
comment:4 Changed on 10/06/2016 at 05:49:37 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4495 - Remove adblockplustests dependency