Opened on 10/10/2016 at 01:49:08 PM

Closed on 01/04/2017 at 03:21:23 PM

#4512 closed change (fixed)

Move preferences file to xml directory

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P5 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29356463/

Description

Background

The Android guideline recommends that all XML files for preference hierarchy to be saved into the res/xml directory.

What to change

Move the file preferences_main and its references from layout folder to xml folder

Attachments (0)

Change History (3)

comment:1 Changed on 10/10/2016 at 02:23:25 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/04/2017 at 03:19:11 PM by abpbot

A commit referencing this issue has landed:
​Issue 4512 - Move preferences file to xml directory

comment:3 Changed on 01/04/2017 at 03:21:23 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.