Opened on 10/14/2016 at 08:33:52 AM
Closed on 10/15/2016 at 09:15:05 PM
Last modified on 10/20/2016 at 01:17:04 PM
#4527 closed defect (fixed)
TypeError: can't access dead object in child/elemHide.js
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #524 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Adblock Plus 2.7.3.4210
Firefox 52.0a1 nightly (2016-10-13)
macOS 10.12
How to reproduce
- Press Ctrl/Cmd+Shift+J to open Browser Console.
- Go back to the browser window and press Ctrl/Cmd+T to open a new tab.
- Type http://cmdrkeene.com/windows-desktop-topology into the location bar and press Enter.
- Look at the Browser Console.
Observed behaviour
The following error message shows up:
TypeError: can't access dead object
child/elemHide.js:372
Expected behaviour
No error messages.
Background
This appears to be a regression from #524. In the observer we verify that the window hasn't been garbage collected by means of calling Cu.isDeadWrapper(). However, later we are accessing subject which is the corresponding document - and it appears that it has been garbage collected independently of the window.
Attachments (0)
Change History (5)
comment:2 Changed on 10/14/2016 at 08:42:16 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 10/15/2016 at 09:14:28 PM by abpbot
comment:4 Changed on 10/15/2016 at 09:15:05 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 10/20/2016 at 01:08:46 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 2.7.3.4214-beta
Firefox Nightly 52.0a1 (2016-10-20) / OS X 10.12
Last edited on 10/20/2016 at 01:17:04 PM
by Ross
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4527 - Don't access potentially dead object in child/elemHide.js