Opened on 10/17/2016 at 01:48:31 PM
Last modified on 12/04/2018 at 03:21:03 PM
#4542 new change
Support "abp:" and "subscripe.adblockplus.org" filter list subscription URLs
Reported by: | mario | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Adblock-Browser-for-iOS | Keywords: | |
Cc: | greiner | Blocked By: | |
Blocking: | #6965 | Platform: | Adblock Browser for iOS |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by mario)
Background
In order to allow users to subscribe to unofficial filter lists (e.g. EasyList Spanish) support for filter list subscription URL's needs to be added.
What to change
Add filter list subscription prompt
- As soon as a filter list subscription URL is tapped, prompt the user whether they wish to add the filter list to their filter list subscriptions as shown in [this screenshot].
Prompt text: TBD
Prompt confirmation text: TBD
Prompt cancellation text: TBD
1.1 If the user cancels the prompt, close the prompt and don't perform any actions
1.2 If the user confirms the prompt, add the new subscription to ABB's default filter list subscription as described under "Add new filter list subscriptions"
Add new filter list subscriptions
- Add a new list component to the "Ad blocking" settings page (Settings->Adblock Plus->Ad blocking) as shown in [this screenshot]
Headline: TBD ("Custom subscriptions")
Content: Empty by default
Visibility: Hidden by default
2.1 As soon as one or more custom filter lists are subscribed (3.), automatically show this element as shown in [this screenshot]
2.2 As soon as all custom filter lists are removed (3.), automatically hide this element as shown in [this screenshot]
- As soon as the subscription of a new filter list has been confirmed (1.2), add a new filter list item to the list new custom filter list component (2.) as shown in [this screenshot]
Text: <filter list name>
3.1 Enable newly added custom filter lists by default
3.2 TBD: Enable users to remove custom filter list items
Additional information
In addition to 1., filter list subscription URLs either start with "abp:subscribe" or with "https://subscribe.adblockplus.org" as documented at #2208.
Will add screenshots, style guide and missing information as soon as assets are ready.