Opened on 05/09/2014 at 10:03:17 AM

Closed on 07/15/2014 at 02:22:59 PM

Last modified on 07/15/2014 at 03:55:43 PM

#455 closed defect (fixed)

Find function in Filter Preferences - No indication when keyword is not found

Reported by: Crits Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.4-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc:, fhd, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by Crits)


Windows 7 x64 SP1
Firefox 29.0

How to reproduce

  1. Open filter preferences
  2. Click the Search button
  3. Start typing a keyword that does not exist in your filter lists

Observed behaviour

No indication (color change or sound) is given when the searched keyword is not found.

Expected behaviour

The search function should mimic the one of Firefox, i.e. at least color the search box background in red, and possibly make a sound, when the keyword is not found.

Attachments (0)

Change History (12)

comment:1 Changed on 05/09/2014 at 10:27:19 AM by mapx

  • Cc added

comment:2 Changed on 05/09/2014 at 10:46:18 AM by philll

  • Type changed from defect to change

That's a not-existing feature and thereby a change request rather than a bug.

comment:3 Changed on 05/13/2014 at 11:40:35 AM by Crits

Note that I made a mistake in the "component" field, it should be Adblock Plus for Firefox and not for Android.

comment:4 Changed on 05/13/2014 at 12:17:32 PM by mapx

  • Component changed from Adblock-Plus-for-Android to Adblock-Plus-for-Firefox

comment:5 Changed on 07/09/2014 at 12:38:11 PM by philll

  • Platform set to Firefox

comment:6 Changed on 07/15/2014 at 10:28:10 AM by trev

  • Cc fhd added
  • Priority changed from Unknown to P3
  • Ready set
  • Type changed from change to defect

Actually, it is a bug - the find bar can indicate failed searches and our code is supposed to tell the find bar to do it. Not sure why it doesn't happen.

comment:7 follow-up: Changed on 07/15/2014 at 10:35:03 AM by trev

  • Cc trev added

Actually, our implementation is correct. It's simply that changed the API once again, onFindResult now expects an object with various properties instead of multiple parameters. At least that's what we have in Firefox 29 and above - @Crits, I guess you meant Firefox 29 rather than Firefox 19?

comment:8 Changed on 07/15/2014 at 11:34:02 AM by trev

  • Owner set to trev

comment:9 Changed on 07/15/2014 at 11:36:53 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed on 07/15/2014 at 02:22:59 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 in reply to: ↑ 7 Changed on 07/15/2014 at 03:55:21 PM by Crits

Replying to trev:

@Crits, I guess you meant Firefox 29 rather than Firefox 19?


comment:12 Changed on 07/15/2014 at 03:55:43 PM by Crits

  • Description modified (diff)

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.