Opened on 10/31/2016 at 02:11:31 PM
Closed on 10/31/2016 at 02:30:34 PM
Last modified on 11/22/2016 at 08:42:39 AM
#4589 closed change (fixed)
Update buildtools dependency to revision dadad687f607
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.8.2-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Attachments (0)
Change History (6)
comment:1 Changed on 10/31/2016 at 02:30:09 PM by abpbot
comment:2 Changed on 10/31/2016 at 02:30:34 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 11/18/2016 at 09:17:19 AM by Ross
After reading the referenced tickets and their patches I'm not sure how to test this?
comment:4 Changed on 11/21/2016 at 11:51:13 AM by trev
You can only test #4544 - you should be able to paste as text in Google Docs using Ctrl/Cmd-Shift-V keyboard shortcut, and the Adblock Plus keyboard shortcut to open blockable items should change into Ctrl/Cmd-Shift-U. However, there appear to be timing issues so occasionally we'll still get the old keyboard shortcut for blockable items.
comment:5 Changed on 11/21/2016 at 03:35:37 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Working as described in #4544. Should I open another ticket for the timing issue (saw it too)?
ABP 2.8.1.4231-beta
Firefox 38 / 49 / Windows 7
Firefox Nightly 53.0a1 / OS X 10.10
comment:6 Changed on 11/22/2016 at 08:42:39 AM by trev
Yes, please open a new ticket, it's not going to block the release.
A commit referencing this issue has landed:
Issue 4589 - Update buildtools dependency to revision dadad687f607