Opened on 11/09/2016 at 09:05:03 AM

Closed on 11/09/2016 at 05:04:23 PM

Last modified on 10/08/2019 at 05:50:08 PM

#4625 closed change (fixed)

moz-extension:// should be a whitelisted scheme

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29362067/

Description

Background

Mozilla introduced moz-extension:// URL scheme for WebExtensions, it is being used for extension pages. So far we didn't whitelist that scheme in Adblock Plus and might still hide content on these pages.

What to change

Add moz-extension:// to the whitelisted schemes, these are special pages that Adblock Plus should not affect.

Attachments (0)

Change History (5)

comment:1 Changed on 11/09/2016 at 09:18:50 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/09/2016 at 05:00:39 PM by abpbot

A commit referencing this issue has landed:
​Issue 4625 - moz-extension:// should be a whitelisted scheme

comment:3 Changed on 11/09/2016 at 05:04:23 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 11/20/2016 at 07:54:07 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Works as expected.

Firefox 49 / Windows 7
Firefox Nightly 53.0a1 (2016-11-17) / Windows 7

comment:5 Changed on 08/01/2019 at 05:06:55 AM by Salman86

spam

Last edited on 10/08/2019 at 05:50:08 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.