Opened on 11/21/2016 at 10:39:48 AM
Closed on 04/06/2017 at 04:46:03 PM
Last modified on 04/07/2017 at 05:24:50 AM
#4657 closed change (fixed)
Add Acceptable Ads API into FilterEngine
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | fhd, oleksandr, asmirnov | Blocked By: | |
| Blocking: | #5121 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
It origins from #4612.
Currently the user of libadblockplus has to manually manage AA subscription which is a bit inconvenient and requires to read setting subscriptions_exceptionsurl. It would be better to provide with such managing API.
What to change
- add the following methods
- FilterEngine::SetAAEnabled(bool)
- FilterEngine::IsAAEnabled()
- Subscription::IsAA() it should allow to find AA subscription among items returned by FilterEngine::GetListedSubscriptions
- FilterEngine::GetAAURL() it seems not an ideal way but already better than to ask user of libadblockplus to read hard-coded property subscriptions_exceptionsurl. Allows to get AA URL when AA is not enabled and is absent locally.
- update Readme file
Attachments (0)
Change History (5)
comment:1 Changed on 12/08/2016 at 01:36:29 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/13/2016 at 03:27:52 PM by asmirnov
- Cc asmirnov added
comment:3 Changed on 04/06/2017 at 04:44:19 PM by abpbot
comment:4 Changed on 04/06/2017 at 04:46:03 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 04/07/2017 at 05:24:50 AM by asmirnov
- Blocking 5121 added
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4657 - Add Acceptable Ads API