Opened on 12/03/2016 at 09:42:31 PM

Closed on 12/05/2016 at 12:27:45 PM

#4697 closed change (fixed)

Add support for WebExtension-based Firefox development builds

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: sebastian, kvas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29366797/

Description (last modified by trev)

Background

We now support creating WebExtension-based Firefox build from adblockpluschrome repository, it should be possible to set up development builds.

What to change

Add support for gecko-webext type to sitescripts.extensions.bin.createNightlies script. This means in particular implementing the new update manifest format (see https://developer.mozilla.org/en-US/Add-ons/Updates) because we won't upload these builds to AMO yet and need to handle updates on our server. Otherwise there isn't really anything special about those builds, it's the same build.py call as always.

Attachments (0)

Change History (5)

comment:1 Changed on 12/05/2016 at 08:42:27 AM by trev

  • Component changed from Unknown to Sitescripts
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/05/2016 at 10:32:56 AM by trev

  • Description modified (diff)

comment:3 Changed on 12/05/2016 at 10:34:29 AM by kvas

  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed on 12/05/2016 at 12:27:16 PM by abpbot

comment:5 Changed on 12/05/2016 at 12:27:45 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.