Opened on 05/13/2014 at 10:21:34 AM

Closed on 05/13/2014 at 12:28:01 PM

Last modified on 05/15/2014 at 03:09:40 PM

#471 closed defect (fixed)

YouTube video ads aren't blocked on Safari again.

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.2-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: trev, philll Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

​http://codereview.adblockplus.org/5096307580469248

Description

Environment

Safari 7

How to reproduce

  1. Go to youtube.com
  2. Click on any video

Observed behaviour

You see prerolls and/or overlay ads.

Expected behaviour

All ads should be blocked.

Attachments (0)

Change History (4)

comment:1 Changed on 05/13/2014 at 10:25:39 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Apparently YouTube updated their website again. It isn't sufficient anymore to patch history.pushState to disable the history API. However patching History.prototype.pushState still does the trick.

comment:2 Changed on 05/13/2014 at 12:28:01 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockpluschrome/rev/3e6870eeec97

comment:3 Changed on 05/14/2014 at 09:53:00 AM by philll

  • Verified working set

comment:4 Changed on 05/15/2014 at 03:09:40 PM by sebastian

  • Ready set

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.