Opened on 12/07/2016 at 01:50:32 PM
Closed on 03/29/2017 at 01:12:59 PM
#4716 closed change (duplicate)
Update adblockpluscore and adblockplusui dependency to TBA
| Reported by: | wspee | Assignee: | wspee |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, sebastian | Blocked By: | #3672, #4915 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by wspee)
Background
#3672 moves antiadblockInit.js from adblockpluscore to adblockplusui so the dependency and the metadata file needs to be updated.
What to change
Update the adblockpluscore dependency to TBA and update the antiadblockInit.js entry in the metadata file accordingly.
Update the adblockplusui dependency to TBA and update the antiadblockInit.js entry in the metadata file accordingly.
Remove the translation for antiadblockInit.js which were added to adblockplusui in TBA and update the metadata files accordingly.
Attachments (0)
Change History (6)
comment:1 Changed on 12/07/2016 at 02:25:42 PM by wspee
- Cc trev added
- Priority changed from P2 to Unknown
comment:2 Changed on 12/19/2016 at 05:32:51 PM by sebastian
- Cc sebastian added
comment:3 Changed on 12/20/2016 at 08:09:27 AM by wspee
- Description modified (diff)
Yes that makes sense. I updated the ticket to also include the translation removal.
comment:4 Changed on 02/21/2017 at 11:20:11 AM by wspee
- Type changed from defect to change
comment:5 Changed on 03/01/2017 at 02:46:57 PM by wspee
- Blocked By 4915 added
Note: See
TracTickets for help on using
tickets.
As I mentioned in this review, I think removing the redundant strings from adblockplus should be done simultaneously with the dependency update.