Opened on 12/14/2016 at 11:34:50 AM

Last modified on 01/04/2017 at 08:53:22 PM

#4733 new change

Refactor nginx module

Reported by: paco Assignee:
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: matze, ferris Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29370627/

Description

Background

The current module mixes both configuration specifics and installation of the package, this leads to cyclic dependencies, for instance, one has to include the ssh module in nginx in order to have the latest updates of the ssl packages.

What to change

Remove the configuration from the nginx module and use an adblockplus::web (or something) defined type so the configuration specifics can be done in a different module.

Attachments (0)

Change History (3)

comment:1 Changed on 12/15/2016 at 10:18:52 AM by matze

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 01/02/2017 at 11:48:16 PM by paco

  • Review URL(s) modified (diff)

comment:3 Changed on 01/04/2017 at 08:53:22 PM by abpbot

A commit referencing this issue has landed:
​Issue 4733 - Extend class nginx to be compatible with Debian releases

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.