Opened on 05/13/2014 at 03:15:55 PM

Closed on 11/10/2017 at 11:15:18 AM

#475 closed change (rejected)

Use new

Reported by: David Rajchenbach-Teller Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc:, trev, arthur Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):


In ABP for Firefox, readFromFile could be simplified.
Recent versions of Gecko offer, { encoding: "utf-8" });

which performs the read and decoding entirely off the main thread.

I'll try and work on a patch in the next few days if I have a little time.

Attachments (0)

Change History (6)

comment:1 Changed on 05/13/2014 at 04:41:08 PM by mapx

  • Cc added

comment:2 Changed on 05/14/2014 at 05:59:00 AM by trev

  • Cc trev added
  • Priority changed from Unknown to P4
  • Ready set
  • Review URL(s) modified (diff)

I'm somewhat undecided on the priority here. The documentation on hasn't been updated yet but it seems that the relevant bug here is which means that this feature was introduced in Firefox 30. So we can either wait until Firefox 31 becomes the new ESR release (October) or we can implement this in a backwards compatible way (this might eat away most of the simplification achieved).

comment:3 Changed on 05/14/2014 at 08:39:11 AM by arthur

  • Cc Trevor arthur added; trev removed

comment:4 Changed on 05/14/2014 at 08:41:38 AM by arthur

  • Cc trev added; Trevor removed

comment:5 Changed on 07/09/2014 at 12:38:11 PM by philll

  • Platform set to Firefox

comment:6 Changed on 11/10/2017 at 11:15:18 AM by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.