Opened on 01/13/2017 at 03:02:55 PM
Closed on 01/30/2018 at 07:22:05 AM
#4797 closed change (fixed)
Separate white box and text from eyeo.com homepage banner
Reported by: | juliandoucette | Assignee: | ire |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Websites | Keywords: | goodfirstbug |
Cc: | jeen, christiane, saroyanm | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by saroyanm)
Background
The text in the banner image on https://eyeo.com/ homepage is not accessible/searchable and it prevents us from further optimizing the file size.
What to change
Change existing eyeo.com banner image, using attached images and overlay the text the way it's currently look on the baner.
Attachments (4)
Change History (14)
comment:1 Changed on 01/16/2017 at 11:54:46 AM by saroyanm
- Ready unset
Changed on 01/16/2017 at 12:14:05 PM by christiane
Changed on 01/16/2017 at 12:14:19 PM by christiane
Changed on 01/16/2017 at 12:14:32 PM by christiane
Changed on 01/16/2017 at 12:14:43 PM by christiane
comment:2 Changed on 01/25/2017 at 06:41:54 PM by juliandoucette
- Priority changed from P3 to Unknown
comment:3 Changed on 01/25/2017 at 06:43:02 PM by juliandoucette
- Priority changed from Unknown to P2
- Ready set
Thanks @christiane!
comment:4 Changed on 01/26/2017 at 10:28:17 AM by saroyanm
- Description modified (diff)
- Priority changed from P2 to P4
Not really sure if this is P2 ticket, Sure it's not that accessible, but still works for majority of people, it's not something that breaks the functionality. I'll mark this P4, let me know if you have objection, also this looks to be goodfirstbug, also description wasn't ready I've updated it.
comment:5 Changed on 01/26/2017 at 10:29:28 AM by saroyanm
- Keywords goodfirstbug added
I think the ticket is not ready still, probably make sense to decide on the image, I thought the decision was to use 1x for usual screens and 2x for High DPI.. Was there a reason why was requested other image sizes ?
comment:6 Changed on 01/18/2018 at 01:58:46 PM by ire
- Owner set to ire
comment:7 Changed on 01/18/2018 at 02:00:38 PM by philll
- Cc philll removed
comment:8 Changed on 01/18/2018 at 04:46:10 PM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 01/30/2018 at 07:21:40 AM by abpbot
A commit referencing this issue has landed:
Issue 4797 - Separate white box and text from eyeo.com homepage banner
comment:10 Changed on 01/30/2018 at 07:22:05 AM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
I think this is not ready yet, let's wait for the image to be provided and mark it as ready afterwards.