Opened on 01/23/2017 at 02:27:27 PM
Closed on 08/16/2017 at 09:22:49 AM
#4833 closed change (rejected)
Enable CrowdIn translations for adblockpluscore, migrate strings
| Reported by: | kzar | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | trev, sebastian, greiner, Shikitita | Blocked By: | |
| Blocking: | #4829 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29372829/ |
||
Description (last modified by kzar)
Background
Little by little we migrated core Adblock Plus code from the adblockplus repository to adblockpluscore. Historically we couldn't do that for the translatable strings since our tools did not allow for translation synchronisation of app-independent projects #2109.
What to change
- Create an adblockpluscore project in Crowdin.
- Add the metadata.generic and build.py files (See #2834.)
- Move the filter_* core strings from global.properties in adblockplus to filter.json in adblockpluscore, synchronise the updated state for both projects with Crowdin.
Attachments (0)
Change History (14)
comment:1 Changed on 01/23/2017 at 02:28:36 PM by kzar
- Blocked By 4829 added
comment:2 Changed on 01/23/2017 at 02:30:19 PM by kzar
- Blocked By 4829 removed
- Blocking 4829 added
comment:3 Changed on 01/23/2017 at 03:29:27 PM by trev
- Priority changed from Unknown to P2
- Ready set
comment:4 Changed on 01/23/2017 at 03:30:00 PM by trev
- Blocking 4829 removed
comment:5 Changed on 01/23/2017 at 03:30:13 PM by trev
- Blocking 4829 added
comment:6 Changed on 01/23/2017 at 03:32:13 PM by trev
- Blocking 4829 removed
comment:7 Changed on 01/23/2017 at 03:32:37 PM by trev
- Blocking 4829 added
comment:8 Changed on 01/24/2017 at 08:21:32 AM by kzar
- Cc Shikitita added
comment:10 Changed on 01/24/2017 at 11:30:16 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:11 Changed on 02/16/2017 at 11:36:56 AM by sebastian
I'm confused, as I'm pretty sure we agreed to move all strings from adblockpluscore to adblockplusui. IMO adding yet another translation project (for the same product) doesn't make anything more manageable. Not to mention the hassle for our (volunteer) translators, to join another translation project, which I have doubts that many will do. Then again considering the few strings we have in adblockplucore, just moving them to adblockplusui, seems a much better option.
comment:12 Changed on 02/16/2017 at 11:37:22 AM by sebastian
comment:13 Changed on 04/03/2017 at 08:18:42 AM by kzar
- Owner kzar deleted
comment:14 Changed on 08/16/2017 at 09:22:49 AM by trev
- Ready unset
- Resolution set to rejected
- Status changed from reviewing to closed
Agreed, it doesn't make sense to have translations in adblockpluscore. As far as adblockpluscore is concerned, these are error codes. We only need to have strings for them in adblockplusui.
OK the state of the adblockpluscore Crowdin project is about there, will upload some reviews shortly.