Opened on 02/15/2017 at 05:30:36 PM

Closed on 03/08/2017 at 12:54:36 PM

#4899 closed change (fixed)

Setup template META description using page variable for eyeo.com

Reported by: saroyanm Assignee: erick
Priority: P4 Milestone:
Module: Websites Keywords:
Cc: juliandoucette, jeen, erick Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29375829/

Description

Background

Currently we are not able to setup Description for the pages (ex. job ads) without using <head> block in eyeo.com.

What to change

Add possibility to specify description from the pages in eyeo.com similar we do for acceptableads.com

Attachments (0)

Change History (5)

comment:1 Changed on 02/15/2017 at 05:34:56 PM by saroyanm

@Erick this ticket is not urgent, while it's still possible to specify description using <head> block for #4898, but if we can tackle it before #4898 we don't need to revert the implementation afterwards.
Is this something you want to tackle ?

comment:2 Changed on 02/15/2017 at 05:47:14 PM by erick

@saroyanm yeah of course. It makes sense to do this before #4898. I am in.

comment:3 Changed on 02/16/2017 at 11:36:42 AM by erick

  • Owner set to erick

comment:4 Changed on 03/08/2017 at 11:33:57 AM by abpbot

A commit referencing this issue has landed:
Issue 4899 - Set template META description on eyeo.com

comment:5 Changed on 03/08/2017 at 12:54:36 PM by erick

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from erick.
 
Note: See TracTickets for help on using tickets.