Opened on 02/20/2017 at 02:30:20 PM

Closed on 06/19/2017 at 09:41:14 AM

#4917 closed change (fixed)

Shrink space around accent section headings and content when section contains cards on acceptableads.com

Reported by:	juliandoucette	Assignee:	ire
Priority:	P2	Milestone:	acceptableads.com/committee cleanup
Module:	Websites	Keywords:
Cc:	jeen, athornburgh, saroyanm, scheer, rraceanu	Blocked By:
Blocking:		Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29457564/

Description

Background

Accent (green) section content (headings, paragraphs) have extra large padding on acceptableads.com. I think this makes sense when the section contains just a heading or quote. But not when the section contains cards too. e.g.

home page (scroll down)
users page (scroll down, worst example)

What to change

Reduce the amount of space under headings/content within accent sections that contain cards.

See attachments for an example using 50% as much space below.

Attachments (6)

Screen Shot 2017-02-20 at 14.25.15-fullpage.png (692.1 KB) - added by juliandoucette on 02/20/2017 at 02:34:45 PM.: Desktop example 1
Screen Shot 2017-02-20 at 14.26.10-fullpage.png (409.6 KB) - added by juliandoucette on 02/20/2017 at 02:35:05 PM.: Mobile example 1
Screen Shot 2017-02-20 at 14.26.26-fullpage.png (450.0 KB) - added by juliandoucette on 02/20/2017 at 02:35:22 PM.: Tablet example 1
Screen Shot 2017-02-20 at 14.28.09-fullpage.png (546.1 KB) - added by juliandoucette on 02/20/2017 at 02:35:45 PM.: Desktop example 2
Screen Shot 2017-02-20 at 14.28.15-fullpage.png (444.6 KB) - added by juliandoucette on 02/20/2017 at 02:36:05 PM.: Tablet example 2
Screen Shot 2017-02-20 at 14.28.19-fullpage.png (473.1 KB) - added by juliandoucette on 02/20/2017 at 02:36:23 PM.: Mobile example 2

Download all attachments as: .zip

Change History (16)

Changed on 02/20/2017 at 02:34:45 PM by juliandoucette

Attachment Screen Shot 2017-02-20 at 14.25.15-fullpage.png added

Desktop example 1

Changed on 02/20/2017 at 02:35:05 PM by juliandoucette

Attachment Screen Shot 2017-02-20 at 14.26.10-fullpage.png added

Mobile example 1

Changed on 02/20/2017 at 02:35:22 PM by juliandoucette

Attachment Screen Shot 2017-02-20 at 14.26.26-fullpage.png added

Tablet example 1

Changed on 02/20/2017 at 02:35:45 PM by juliandoucette

Attachment Screen Shot 2017-02-20 at 14.28.09-fullpage.png added

Desktop example 2

Changed on 02/20/2017 at 02:36:05 PM by juliandoucette

Attachment Screen Shot 2017-02-20 at 14.28.15-fullpage.png added

Tablet example 2

Changed on 02/20/2017 at 02:36:23 PM by juliandoucette

Attachment Screen Shot 2017-02-20 at 14.28.19-fullpage.png added

Mobile example 2

comment:1 Changed on 02/20/2017 at 02:51:50 PM by juliandoucette

Sorry about the large screenshots :(

I'll resize them if you think it's necessary.

comment:2 Changed on 03/07/2017 at 02:29:43 PM by juliandoucette

Milestone set to acceptableads.com/committee 160301
Ready set

Product approved via email.

comment:3 Changed on 03/07/2017 at 02:30:25 PM by juliandoucette

Cc scheer rraceanu added

comment:4 Changed on 03/07/2017 at 03:05:33 PM by juliandoucette

Milestone changed from acceptableads.com/committee 160301 to acceptableads.com/committee 160315

comment:5 Changed on 03/07/2017 at 03:11:18 PM by juliandoucette

Milestone changed from acceptableads.com/committee 160315 to acceptableads.com/committee 160315 cleanup

comment:6 Changed on 04/10/2017 at 04:12:38 PM by juliandoucette

Priority changed from Unknown to P2

Prioritizing because this effects other issues.

comment:7 Changed on 06/05/2017 at 02:06:47 PM by ire

Owner set to iaderinokun

comment:8 Changed on 06/07/2017 at 08:56:23 AM by ire

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:9 Changed on 06/19/2017 at 09:39:54 AM by abpbot

A commit referencing this issue has landed:
Issue 4917 - Shrink space around accent section headings and content when section contains cards on acceptableads.com

comment:10 Changed on 06/19/2017 at 09:41:14 AM by ire

Resolution set to fixed
Status changed from reviewing to closed

Context Navigation