Opened on 02/27/2017 at 02:47:28 PM
Closed on 03/21/2017 at 10:12:40 AM
#4942 closed defect (fixed)
Failed to build due to "sorry, unimplemented: mangling dotstar_expr"
| Reported by: | asmirnov | Assignee: | asmirnov |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Libadblockplus-Android | Keywords: | |
| Cc: | sergz, fhd | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Trying to build libadblockplus-android on new macbook i'm getting "sorry, unimplemented: mangling dotstar_expr" error (see full text in attached build_error.txt) with gradlew. Something related to issue #768
How to reproduce
- Run ./gradlew clean assembleDebug
- Get build error
...
Observed behaviour
The project should be built
Expected behaviour
The project build fails on ndk compilation
Attachments (1)
Change History (6)
Changed on 02/27/2017 at 02:47:41 PM by asmirnov
comment:1 Changed on 02/27/2017 at 02:51:53 PM by asmirnov
comment:2 Changed on 02/27/2017 at 02:52:28 PM by asmirnov
BTW someone had this issue: https://adblockplus.org/forum/viewtopic.php?f=15&t=50021
comment:3 Changed on 02/28/2017 at 08:50:40 AM by asmirnov
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/21/2017 at 10:12:05 AM by abpbot
A commit referencing this issue has landed:
Issue 4942 - Failed to build due to "sorry, unimplemented: mangling dotstar_expr"
comment:5 Changed on 03/21/2017 at 10:12:40 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
this can be fixed by using one of the lines in https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-android/jni/Application.mk:
1) NDK_TOOLCHAIN_VERSION := clang (use clang toolchain)
2) NDK_TOOLCHAIN_VERSION := 4.8 (use gcc toolchain version 4.8)
The preferred solution will be discussed with Sergei (in order to have the same toolchain for both libadblockplus and libadblockplus-android