Opened on 02/28/2017 at 11:55:37 AM

Closed on 03/20/2017 at 12:22:14 PM

#4944 closed change (fixed)

Provide an asynchronous API to create FilterEngine

Reported by: sergz Assignee: sergz
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #4931 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29377064/

Description

Background

In FilterEngine constructor we have not good way to wait until it's initialized and we do need an asynchronous way to create FilterEngine, for example, in libadblockplus-android we create yet one thread for it.

What to change

Get rid of polling approach and expose asynchronous method to simplify the code of clients of libadblockplus.

Additional notes

Another thing is that in order to do #4931 we have to touch this part of the code, that's because it's blocking for #4931.

Attachments (0)

Change History (3)

comment:1 Changed on 02/28/2017 at 02:35:42 PM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/20/2017 at 12:20:56 PM by abpbot

A commit referencing this issue has landed:
​Issue 4944 - Make creation of FilterEngine asynchronous.

comment:3 Changed on 03/20/2017 at 12:22:14 PM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.