Opened on 03/13/2017 at 12:24:05 PM

Closed on 10/24/2017 at 10:39:30 AM

#4981 closed change (fixed)

Measure and improve test coverage of CMS

Reported by: kvas Assignee: jsonesen
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29383956

Description (last modified by jsonesen)

Background

Recently we have tried to improve the style guide conformance of a part of CMS code. Unfortunately it led to regressions that were not picked up by existing test suite and ended up in production. In order to mitigate similar situations in the future we would like to start measuring test coverage of CMS code and generating a line by line coverage report.

What to change

Add generation of a test coverage report (using pytest-cov) to the test suite of CMS. Further coverage of converters.py can be achieved by adding additional content to the test site such as link or scripts tags.

Attachments (0)

Change History (5)

comment:1 Changed on 03/18/2017 at 09:21:14 AM by jsonesen

  • Owner set to jsonesen
  • Review URL(s) modified (diff)

comment:2 Changed on 03/18/2017 at 09:21:22 AM by jsonesen

  • Status changed from new to reviewing

comment:3 Changed on 03/20/2017 at 09:42:19 AM by abpbot

A commit referencing this issue has landed:
Issue 4981 - Adds test coverage report

comment:4 Changed on 03/20/2017 at 09:44:31 AM by jsonesen

  • Description modified (diff)

comment:5 Changed on 10/24/2017 at 10:39:30 AM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jsonesen.
 
Note: See TracTickets for help on using tickets.