Opened on 03/21/2017 at 10:02:24 PM
Closed on 09/05/2019 at 02:29:44 PM
#5025 closed change (duplicate)
Implement Filter Groups in AdBlock Plus for WebExtensions
| Reported by: | ExE Boss | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner | Blocked By: | #5158 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
In AdBlock Plus for Firefox, custom filters are grouped into filter groups, which can be toggled on or off independently.
In AdBlock Plus for WebExtensions, all custom filters are one single group which can't be turned off without removing the filter(s).
.png.html "Custom Filters Comparison (WebExtensions × Firefox)")
I request that in AdBlock Plus for WebExtensions, the custom filters are changed to work similarly to the way they are implemented in AdBlock Plus for Firefox. (Grouped into filter groups and be toggle-able independently)
The reason for this is to provide feature parity in the WebExtension and the Firefox versions of AdBlock Plus ease the transition from a Bootstrapped extension to a WebExtension in AdBlock Plus for Firefox.
What to change
See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/28
Attachments (1)
Change History (11)
Changed on 03/21/2017 at 10:02:59 PM by ExE Boss
comment:1 Changed on 03/21/2017 at 10:14:13 PM by ExE Boss
Summary should be: Implement Custom Filter Groups in AdBlock Plus for WebExtensions
comment:2 Changed on 03/29/2017 at 09:44:15 AM by trev
- Resolution set to duplicate
- Status changed from new to closed
New options page for Chrome and WebExtensions is #2706, the current options page isn't meant to stay.
comment:3 Changed on 03/29/2017 at 09:44:36 AM by trev
- Cc trev added
comment:4 Changed on 04/03/2017 at 02:40:23 PM by ExE Boss
It seems like you misunderstood what I mean.
I am talking about the new options page having the custom filters in a single filter list instead of multiple custom filter list groups.
I checked the issue you provided me with, and nowhere does it mention allowing the user to keep multiple custom filter lists. Instead, it seems like the plan is to have the new options page merge all the current custom filter list groups into a single large custom filter list.
comment:5 Changed on 04/04/2017 at 08:04:44 AM by trev
- Cc greiner added
- Component changed from Unknown to User-Interface
@greiner: Do we currently have plans to implement organizing user filters as something better than a plain list? If not, maybe this should be reopened and block #2706.
comment:6 Changed on 04/04/2017 at 10:37:49 AM by greiner
- Blocked By 2706 added
- Resolution duplicate deleted
- Status changed from closed to reopened
@trev This is not part of #2706 which still refers to the milestone of having feature-parity with Chrome. There's no meta ticket for Firefox tickets we want to port over after that.
Anyway, I reopened it because there's no other ticket for it yet but leaving it as "not ready" due to it lacking information in regards to functionality, design and timeline. Those are somewhat blocked by (at least) the design finalization for #2706.
comment:7 Changed on 04/20/2017 at 11:26:49 AM by greiner
- Blocked By 5158 added; 2706 removed
comment:8 Changed on 12/21/2017 at 11:27:49 AM by fhd
- Cc trev removed
comment:9 Changed on 08/06/2018 at 05:54:49 PM by greiner
- Description modified (diff)
Added reference to GitLab issue.
comment:10 Changed on 09/05/2019 at 02:29:44 PM by greiner
- Resolution set to duplicate
- Status changed from reopened to closed
Closing this ticket in favor of ui#28 so please follow along there.
Note that, in the meantime, we have added support for en-/disabling one or more custom filters (see ui#15 and ui#174) as part of Adblock Plus 3.6.
.png){kind=link}
Custom Filters Comparison (WebExtensions × Firefox)