Opened on 03/24/2017 at 04:26:02 PM
Closed on 04/20/2017 at 01:32:09 PM
#5034 closed change (fixed)
Get rid of JsValuePtr and use JsValue instead
Reported by: | sergz | Assignee: | hfiguiere |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | fhd, hfiguiere | Blocked By: | #3589 |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29416579 |
Description
Reasons
On practice it's visible that in most or even in all cases we don't need JsValuePtr, merely JsValue is enough, and the code can be still efficient because currently used compilers already support move-semantics. The code without addition wrapper (std::shared_ptr<JsValue>) should be simpler to use and less error-prone.
What to change
Gradually get rid of JsValuePtr.
Attachments (0)
Change History (9)
comment:1 Changed on 03/27/2017 at 04:45:38 PM by sergz
comment:2 Changed on 04/13/2017 at 01:35:51 PM by hfiguiere
- Owner set to hfiguiere
comment:4 Changed on 04/18/2017 at 09:19:51 PM by hfiguiere
- Status changed from new to reviewing
comment:5 Changed on 04/19/2017 at 03:16:13 PM by abpbot
Some commits referencing this issue have landed:
comment:8 Changed on 04/20/2017 at 01:29:48 PM by abpbot
Some commits referencing this issue have landed:
comment:9 Changed on 04/20/2017 at 01:32:09 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
I think next steps should be in commmits respectively
afterwards