Opened on 05/16/2014 at 12:50:01 PM

Closed on 07/11/2014 at 08:17:46 AM

#505 closed change (fixed)

[Typed objects] Implement array helper methods

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By: #151
Blocking: #145 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6273062181797888

Description

Background

#151 implemented array types with the minimal functionality. A few convenience methods won't hurt.

What to change

At the very least, array.push() and array.pop() methods should be added. Optionally, we can also implement array.splice(), array.unshift() and array.shift (with the usual performance warnings).

Attachments (0)

Change History (3)

comment:1 Changed on 05/17/2014 at 09:02:15 PM by trev

  • Owner set to trev

comment:2 Changed on 05/17/2014 at 09:04:15 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 07/11/2014 at 08:17:46 AM by trev

  • Platform set to Unknown
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.