Opened on 03/29/2017 at 02:15:36 PM
Closed on 03/30/2017 at 10:14:46 AM
#5057 closed change (fixed)
Update adblockpluscore dependency to revision 3bdddf0e8343
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.9-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #5048 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We need to import changes from #4919 so that automatic backups go through the same I/O module as everything else.
What to change
Update dependency and make sure the code in chrome/content/ui/filters-backup.js can deal with an async response.
What to test
List of automatic backups in Filter Preferences (click Backup and Restore button) should be populated with correct dates. Restoring a backup should work.
Attachments (0)
Change History (3)
comment:1 Changed on 03/29/2017 at 02:22:07 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/30/2017 at 10:14:14 AM by abpbot
comment:3 Changed on 03/30/2017 at 10:14:46 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5057 - Update adblockpluscore dependency to revision 3bdddf0e8343