Opened on 03/30/2017 at 07:57:08 AM
Closed on 04/18/2017 at 08:43:26 AM
#5062 closed change (fixed)
[emscripten] Allow generation of custom bindings code
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4122 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We currently implemented the awkward concept of "class initializers," currently used to create RegExpFilter.prototype.typeMap object and populate it with constants from C++. This is suboptimal as the same information could be added to the binding statically with much smaller impact on startup time.
What to change
Instead of class initializers, implement custom bindings generators - functions that will be called during bindings generation and can produce additional code. In case of RegExpFilter the complication is that this generation has to rely on data structures only available in the RegExpFilter.cpp file. This means that all C++ have to be processed in the bindings generation step, not merely bindings.cpp.
Attachments (0)
Change History (4)
comment:1 Changed on 03/30/2017 at 08:00:16 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/15/2017 at 08:27:08 AM by trev
- Summary changed from Allow generation of custom bindings code to [emscripten] Allow generation of custom bindings code
comment:3 Changed on 04/18/2017 at 08:42:12 AM by abpbot
comment:4 Changed on 04/18/2017 at 08:43:26 AM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 5062 - [emscripten Allow generation of custom bindings code]