Opened on 04/06/2017 at 10:46:50 AM

Closed on 04/10/2017 at 05:48:47 AM

#5113 closed change (fixed)

Add support to buildtools/packagerChrome.py for json files in top level directory

Reported by: jsonesen Assignee: jsonesen
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, kvas Blocked By:
Blocking: #5083 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29404598/

Description

Background

We are merging the chrome subdirectory of adblockpluschrome into the top level directory, Sebastian noticed that the managed-storage-schema.json is excluded because we explicitly gather files by type from the top level structure and only have html, xml, and js being added to the build. This worked before because we configured the mapping in metadata.chrome.

What to change

Add .json support to packagerChrome.py in buildtools

Attachments (0)

Change History (5)

comment:1 Changed on 04/06/2017 at 10:47:10 AM by jsonesen

  • Cc sebastian kvas added

comment:2 Changed on 04/06/2017 at 10:58:39 AM by jsonesen

  • Review URL(s) modified (diff)

comment:3 Changed on 04/06/2017 at 11:34:43 AM by sebastian

  • Component changed from Sitescripts to Build-and-Release-Tools
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed on 04/08/2017 at 02:41:24 PM by abpbot

comment:5 Changed on 04/10/2017 at 05:48:47 AM by jsonesen

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jsonesen.
 
Note: See TracTickets for help on using tickets.