Opened on 04/14/2017 at 07:58:48 AM

Closed on 11/09/2018 at 05:55:54 PM

#5140 closed change (fixed)

Add tests for settings storage

Reported by: asmirnov Assignee:
Priority: P4 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29412555/
​https://gitlab.com/eyeo/adblockplus/libadblockplus-android/merge_requests/9

Description

Background

In order to control code quality it's better to have it tests covered. We need to add tests for SharedPrefsStorage class.

What to change

Add tests for SharedPrefsStorage class.

Attachments (0)

Change History (8)

comment:1 Changed on 04/14/2017 at 08:14:12 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 10/30/2018 at 07:47:40 AM by asmirnov

  • Status changed from reviewing to reopened

comment:3 Changed on 10/30/2018 at 07:50:34 AM by asmirnov

  • Blocked By 6971 added

comment:4 Changed on 10/30/2018 at 07:50:55 AM by asmirnov

Blocked by ​https://gitlab.com/eyeo/adblockplus/libadblockplus-android/issues/5

Last edited on 10/30/2018 at 05:33:55 PM by asmirnov

comment:5 Changed on 10/30/2018 at 10:00:06 AM by asmirnov

Blocked by ​https://gitlab.com/eyeo/adblockplus/libadblockplus-android/merge_requests/6

comment:6 Changed on 10/30/2018 at 10:00:14 AM by asmirnov

  • Blocked By 6971 removed

comment:7 Changed on 10/30/2018 at 06:54:59 PM by asmirnov

  • Review URL(s) modified (diff)

comment:8 Changed on 11/09/2018 at 05:55:54 PM by asmirnov

  • Resolution set to fixed
  • Status changed from reopened to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.