Opened on 04/29/2017 at 07:31:54 PM

Closed on 05/04/2017 at 08:39:24 AM

#5201 closed change (fixed)

[emscripten] Replace EM_ASM calls by a custom JavaScript library

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29425555/

Description (last modified by trev)

Background

EM_ASM calls in our code have several disadvantages:

  • No type safety.
  • Hard to replace in libadblockplus by a C++ implementation (if no JS engine present).
  • These will make switching to WebAssembly more complicated.

What to change

Replace EM_ASM calls by a custom JavaScript library which will ​expose a C API. Positive side-effect of this approach: around 1% saved in code size.

Attachments (0)

Change History (4)

comment:1 Changed on 04/29/2017 at 07:32:39 PM by trev

  • Description modified (diff)

comment:2 Changed on 04/30/2017 at 07:07:41 AM by trev

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 05/04/2017 at 08:28:25 AM by abpbot

A commit referencing this issue has landed:
​Issue 5201 - [emscripten Replace EM_ASM calls by a custom JavaScript library]

comment:4 Changed on 05/04/2017 at 08:39:24 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.