Opened on 05/08/2017 at 02:06:26 PM
Closed on 05/23/2017 at 01:15:54 PM
Last modified on 07/10/2017 at 01:53:28 PM
#5220 closed change (fixed)
Update lib/io.js for chrome add-on
| Reported by: | hfiguiere | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-1.13.3-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | #5094 | Platform: | Chrome |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by hfiguiere)
Background
Following #5059, we change the io.js API to use promises in libadblockpluschrome
This will import the following changes:
- #5059 - Simplify I/O API and FilterStorage implementation
- #5153 - Simplify patterns.ini parsing
- #4796 - Use a modern JS engine in the browser tests and convert all files to ECMAScript 6
- Misc test fixes.
What to change
- Bump dependencies for core
- Modify lib/io.js to return promise where needed
Attachments (0)
Change History (10)
comment:1 Changed on 05/08/2017 at 02:10:45 PM by hfiguiere
- Cc trev added
comment:2 Changed on 05/08/2017 at 02:13:53 PM by hfiguiere
comment:3 Changed on 05/08/2017 at 02:17:12 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 05/08/2017 at 03:16:41 PM by trev
If this is a dependency update, it should list all changes being imported and their implications. This way we make sure that we know which changes go into a milestone (only this issue will be listed there, not the issues you are importing) and that testers know what needs to be tested. You can see this in #3957 and #3835 for example.
comment:7 Changed on 05/23/2017 at 01:14:15 PM by abpbot
A commit referencing this issue has landed:
Issue 5220 - Update the IO API
comment:8 Changed on 05/23/2017 at 01:15:54 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 05/23/2017 at 01:19:35 PM by hfiguiere
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
comment:10 Changed on 07/10/2017 at 01:53:28 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. IO related functionality like filter storage seems okay.
ABP 1.13.2.1785
Chrome 49 / 59 / Windows 7
Opera 37 / 45 / Windows 7
This needs to be done for issue #5094 as this changes are in core already.