Opened on 05/12/2017 at 05:17:24 PM

Closed on 05/17/2017 at 02:42:43 PM

#5244 closed defect (fixed)

[ABP for Samsung Internet] - Misaligned text in Korean

Reported by: Shikitita Assignee: jwangenheim
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: jwangenheim, diegocarloslima, mario Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29439588/

Description

Environment

Platform: Samsung S6
OS: Android 6.0.1

How to reproduce

  1. Install Adblock Plus for Samsung Internet
  2. Without enabling the content blocking functionality in Samsung Internet, change the device's language into Korean
  3. Access ABP for Samsung Internet making sure that the steps on how to enable it on Samsung Internet are still displayed
  1. Change now the device's language into German and proceed again with step number 3

Observed behaviour

The text "Configure Samsung Internet" in Korean is misplaced to the left instead of centered like the rest of the languages.

This occurs with the steps for both Samsung Internet v. 4 and v. 5.

Expected behaviour

The text should be displayed in the centre in order to keep consistency with the rest of the languages as well as for aesthetic reasons.

Attachments (2)

Misaligned Korean Text.png (182.6 KB) - added by Shikitita on 05/12/2017 at 05:17:36 PM.
Centered German Text.png (203.4 KB) - added by Shikitita on 05/12/2017 at 05:17:49 PM.

Download all attachments as: .zip

Change History (6)

Changed on 05/12/2017 at 05:17:36 PM by Shikitita

Changed on 05/12/2017 at 05:17:49 PM by Shikitita

comment:1 Changed on 05/16/2017 at 07:41:18 AM by jwangenheim

  • Owner set to jwangenheim

comment:2 Changed on 05/16/2017 at 11:59:23 AM by jwangenheim

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 05/17/2017 at 02:35:38 PM by abpbot

A commit referencing this issue has landed:
Issue 5244 - Misaligned text in Korean

comment:4 Changed on 05/17/2017 at 02:42:43 PM by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.0
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
 
Note: See TracTickets for help on using tickets.