Opened on 06/15/2017 at 10:29:24 AM

Closed on 08/24/2017 at 11:36:39 AM

Last modified on 09/20/2017 at 08:45:20 AM

#5321 closed change (fixed)

Workaround Edge not supporting webRequest.ResourceType

Reported by: oleksandr Assignee: oleksandr
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29458601/

Description

Background

We are currently relying on webRequest.ResourceType for deciding if we need to use a wrapper for WebSockets. Edge does not support that property, so we need to work around that.

What to change

Make sure the wrapper is used if webRequest.ResourceType is undefined.

Attachments (0)

Change History (4)

comment:1 Changed on 07/11/2017 at 04:19:06 PM by kzar

  • Cc kzar sebastian added
  • Priority changed from Unknown to P3
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 07/11/2017 at 04:20:46 PM by kzar

  • Priority changed from P3 to P2

comment:3 Changed on 08/24/2017 at 11:36:39 AM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

This was pushed as part of #5315

comment:4 Changed on 09/20/2017 at 08:45:20 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. WebSocket blocking works in Edge (and still works, appears in the devtools panel etc. in other WebEx browsers).

ABP 0.9.11.1849
Edge 40 / Windows 10

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 10
Opera 36 / 47 / Windows 10

ABP 2.99.0.1838beta
Firefox 50 / 55 / Windows 10

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from oleksandr.
 
Note: See TracTickets for help on using tickets.