Opened on 06/19/2017 at 09:34:18 AM
Closed on 04/05/2018 at 01:01:09 PM
#5327 closed defect (incomplete)
Refactor use of %headings selector on acceptableads.com
| Reported by: | ire | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | juliandoucette, saroyanm, wspee, ire | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In the acceptableads.com SCSS, there is a a %headings placeholder selector, which targets all headings:
h1, h2, h3, h4, h5, h6 .h1, .h2, .h3, .h4, .h5, .h6
{
@extend %headings !optional;
}
This is used in several places to target specific headings. For example, this selector which targets a header within a card:
.card %headings
{
@extend h3;
}
This results is unnecessarily long selectors when the CSS is generated.
What to change
Refactor all uses of the %headings selector, where a class can be applied instead. For example:
.card .card-heading
{
@extend h3;
}
Attachments (0)
Change History (5)
comment:2 Changed on 07/12/2017 at 01:54:41 PM by juliandoucette
Therefore, I think it's better to define component heading styles individually instead of extending default heading styles.
comment:3 Changed on 07/12/2017 at 01:55:46 PM by juliandoucette
- Keywords goodfirstbug added
- Priority changed from Unknown to P4
- Review URL(s) modified (diff)
comment:4 Changed on 07/13/2017 at 08:35:21 AM by ire
- Cc ire added
comment:5 Changed on 04/05/2018 at 01:01:09 PM by juliandoucette
- Resolution set to incomplete
- Status changed from new to closed
I don't think that it's necessary to migrate this issue. We may re-address this or similar in a larger refactoring or redesign effort in the future if necessary.
Relevant @extend gotchas:
Also, IIRC there is no concept of @extend in CSS3.