Opened on 07/13/2017 at 09:28:15 AM
Closed on 10/17/2017 at 03:07:40 PM
#5414 closed change (fixed)
Add style guide page to help.eyeo.com
| Reported by: | ire | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | help.eyeo.com 1.0.0 |
| Module: | Websites | Keywords: | |
| Cc: | juliandoucette, wspee, saroyanm, kvas | Blocked By: | #5336, #5413 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Include basic style guide from website-defaults into the Help Center
Attachments (0)
Change History (13)
comment:1 Changed on 07/14/2017 at 07:47:18 AM by ire
- Milestone set to help.eyeo.com 1.0.0
comment:2 Changed on 07/20/2017 at 12:16:20 PM by juliandoucette
- Cc saroyanm added
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 07/20/2017 at 12:16:48 PM by juliandoucette
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 07/20/2017 at 12:18:20 PM by juliandoucette
- Ready unset
- Review URL(s) modified (diff)
- Summary changed from Add style guide to help.eyeo.com to Add style guide page to help.eyeo.com
comment:5 Changed on 07/27/2017 at 08:15:55 AM by ire
- Status changed from reviewing to reopened
comment:6 follow-up: ↓ 7 Changed on 09/15/2017 at 09:22:37 AM by ire
@juliandoucette
I'm not sure it makes sense to implement this by copy/pasting the styleguide includes from website-defaults. I think we should wait until #5336 has been implemented then add this then. What do you think?
comment:7 in reply to: ↑ 6 Changed on 09/18/2017 at 01:24:28 PM by juliandoucette
- Cc kvas added
Replying to ire:
@juliandoucette
I'm not sure it makes sense to implement this by copy/pasting the styleguide includes from website-defaults. I think we should wait until #5336 has been implemented then add this then. What do you think?
That depends if #5336 is likely to be completed soon. What do you think @kvas?
comment:8 Changed on 09/18/2017 at 04:13:36 PM by juliandoucette
- Priority changed from P2 to P3
comment:9 follow-up: ↓ 10 Changed on 09/18/2017 at 09:54:02 PM by kvas
That depends if #5336 is likely to be completed soon. What do you think @kvas?
It's not that much work really, only to start and to finish, as we say in Russia. Thanks for bugging me, I will prioritize it more.
comment:10 in reply to: ↑ 9 Changed on 09/19/2017 at 08:25:27 AM by ire
- Blocked By 5336 added
comment:11 Changed on 10/06/2017 at 10:28:35 AM by ire
- Ready set
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:12 Changed on 10/17/2017 at 03:07:14 PM by abpbot
A commit referencing this issue has landed:
Issue 5414 - Add style guide page to help.eyeo.com
comment:13 Changed on 10/17/2017 at 03:07:40 PM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
oops :p