Opened on 07/18/2017 at 08:51:46 PM

Closed on 07/20/2017 at 07:36:27 PM

Last modified on 08/09/2017 at 06:55:42 PM

#5426 closed defect (fixed)

ABP isn't packaged in the apk

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: #5412 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29491669/

Description (last modified by diegocarloslima)

In Firefox 45, Mozilla has changed how files are packaged into the apk (More info here) and thus, ABP is not being packaged int the apk root /extensions/folder anymore. Seems that they went for an approach to avoid putting folders into the apk root folder and instead, they're using the /assets/ folder. We need to investigate how to put our extension back into the apk and possibly, follow the same approach by using the /assets/ folder.

Attachments (0)

Change History (6)

comment:1 Changed on 07/18/2017 at 10:16:26 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 07/19/2017 at 03:56:13 PM by diegocarloslima

  • Description modified (diff)

comment:3 Changed on 07/20/2017 at 07:35:57 PM by abpbot

A commit referencing this issue has landed:
Issue 5426 - ABP isn't packaged in the apk

comment:4 Changed on 07/20/2017 at 07:36:27 PM by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/01/2017 at 08:59:04 PM by diegocarloslima

  • Milestone changed from Adblock-Browser-for-Android-next to Adblock-Browser-for-Android-1.2.0

comment:6 Changed on 08/09/2017 at 06:55:42 PM by abpbot

A commit referencing this issue has landed:
Issue 5426 - ABP isn't packaged in the apk

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
 
Note: See TracTickets for help on using tickets.